[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 02/11] hw/char: remove sh_serial.
|
From: |
Yoshinori Sato |
|
Subject: |
Re: [PATCH 02/11] hw/char: remove sh_serial. |
|
Date: |
Sun, 06 Jun 2021 23:37:11 +0900 |
|
User-agent: |
Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (Gojō) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (arm-unknown-linux-androideabi) MULE/6.0 (HANACHIRUSATO) |
On Fri, 04 Jun 2021 19:08:07 +0900,
Peter Maydell wrote:
>
> On Thu, 27 May 2021 at 06:24, Yoshinori Sato <ysato@users.sourceforge.jp>
> wrote:
> >
> > Migrate to renesas_sci.
> >
> > Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
> > ---
> > hw/char/sh_serial.c | 431 --------------------------------------------
> > MAINTAINERS | 4 +-
> > hw/char/Kconfig | 3 -
> > hw/char/meson.build | 1 -
> > 4 files changed, 2 insertions(+), 437 deletions(-)
> > delete mode 100644 hw/char/sh_serial.c
>
> This won't compile, because there are still boards which use
> the old code you are removing here. The patchset has to be able
> to compile and work at every step, so you need to first add new
> devices, then convert the boards to use them, and then as the
> last step you can remove the old implementations.
>
> Checking, I find that patch 1 doesn't compile either.
>
> thanks
> -- PMM
OK. I will sent v2.
--
Yoshinori Sato