Re: [PATCH v16 85/99] target/arm: cpu-pauth: new module for ARMv8.3 Pointer Authentication

[Richard Henderson]

On 6/4/21 8:52 AM, Alex Bennée wrote:
> From: Claudio Fontana <cfontana@suse.de>
>
> Pointer Authentication is an AARCH64-only ARMv8.3 optional
> extension, whose cpu properties can be separated out in its own module.
>
> Signed-off-by: Claudio Fontana <cfontana@suse.de>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>   target/arm/cpu.h           |  3 --
>   target/arm/tcg/cpu-pauth.h | 34 ++++++++++++++++++++
>   target/arm/cpu.c           |  1 +
>   target/arm/cpu64.c         | 35 ++-------------------
>   target/arm/tcg/cpu-pauth.c | 63 ++++++++++++++++++++++++++++++++++++++
>   target/arm/tcg/meson.build |  1 +
>   6 files changed, 101 insertions(+), 36 deletions(-)
>   create mode 100644 target/arm/tcg/cpu-pauth.h
>   create mode 100644 target/arm/tcg/cpu-pauth.c
>
> diff --git a/target/arm/cpu.h b/target/arm/cpu.h
> index e9bfb6f575..02e0fe5dbd 100644
> --- a/target/arm/cpu.h
> +++ b/target/arm/cpu.h
> @@ -216,13 +216,10 @@ typedef struct ARMPredicateReg {
>       uint64_t p[DIV_ROUND_UP(2 * ARM_MAX_VQ, 8)] QEMU_ALIGNED(16);
>   } ARMPredicateReg;
>   
> -void arm_cpu_pauth_finalize(ARMCPU *cpu, Error **errp);
>   /* In AArch32 mode, PAC keys do not exist at all.  */
>   typedef struct ARMPACKey {
>       uint64_t lo, hi;
>   } ARMPACKey;
> -#else
> -static inline void arm_cpu_pauth_finalize(ARMCPU *cpu, Error **errp) { }
>   
>   #endif /* TARGET_AARCH64 */
>   
> diff --git a/target/arm/tcg/cpu-pauth.h b/target/arm/tcg/cpu-pauth.h
> new file mode 100644
> index 0000000000..af127876fe
> --- /dev/null
> +++ b/target/arm/tcg/cpu-pauth.h
> @@ -0,0 +1,34 @@
> +/*
> + * QEMU AArch64 Pointer Authentication Extensions
> + *
> + * Copyright (c) 2013 Linaro Ltd
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License
> + * as published by the Free Software Foundation; either version 2
> + * of the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, see
> + * <http://www.gnu.org/licenses/gpl-2.0.html>
> + */
> +
> +#ifndef CPU_PAUTH_H
> +#define CPU_PAUTH_H
> +
> +/* ARMv8.3 pauth is an AARCH64 option, only include this for TARGET_AARCH64 */
> +
> +#include "cpu.h"
> +
> +/* called by arm_cpu_finalize_features in realizefn */
> +void arm_cpu_pauth_finalize(ARMCPU *cpu, Error **errp);
> +
> +/* add the CPU Pointer Authentication properties */
> +void cpu_pauth_add_props(Object *obj);
> +
> +#endif /* CPU_PAUTH_H */

Similar comments re "cpu.h" and the proliferation of headers.
Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~