qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v16 61/99] target/arm: remove broad "else" statements when ch


From: Richard Henderson
Subject: Re: [PATCH v16 61/99] target/arm: remove broad "else" statements when checking accels
Date: Sat, 5 Jun 2021 09:13:33 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1

On 6/4/21 8:52 AM, Alex Bennée wrote:
From: Claudio Fontana<cfontana@suse.de>

There might be more than just KVM and TCG in the future,
so where appropriate, replace broad "else" statements
with the appropriate if (accel_enabled()) check.

Also invert some checks for !kvm_enabled() or !tcg_enabled()
where it seems appropriate to do so.

Note that to make qtest happy we need to perform gpio
initialization in the qtest_enabled() case as well.

Hopefully we do not break any Xen stuff.

Signed-off-by: Claudio Fontana<cfontana@suse.de>
Cc: Julien Grall<jgrall@amazon.com>
Cc: Stefano Stabellini<sstabellini@kernel.org>
Cc: Olaf Hering<OHering@suse.com>
Cc: Alex Bennée<alex.bennee@linaro.org>
Signed-off-by: Alex Bennée<alex.bennee@linaro.org>
---
  target/arm/cpu.c     |  9 +++++----
  target/arm/cpu64.c   |  9 +++++----
  target/arm/machine.c | 18 ++++++------------
  3 files changed, 16 insertions(+), 20 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]