[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v16 45/99] target/arm: move sve_exception_el out of TCG helpers
From: |
Alex Bennée |
Subject: |
[PATCH v16 45/99] target/arm: move sve_exception_el out of TCG helpers |
Date: |
Fri, 4 Jun 2021 16:52:18 +0100 |
From: Claudio Fontana <cfontana@suse.de>
we need this for KVM too.
Signed-off-by: Claudio Fontana <cfontana@suse.de>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
target/arm/cpu-sysemu.c | 62 +++++++++++++++++++++++++++++++++++++++
target/arm/cpu-user.c | 5 ++++
target/arm/tcg/helper.c | 64 -----------------------------------------
3 files changed, 67 insertions(+), 64 deletions(-)
diff --git a/target/arm/cpu-sysemu.c b/target/arm/cpu-sysemu.c
index 7a314bf805..7cc721fe68 100644
--- a/target/arm/cpu-sysemu.c
+++ b/target/arm/cpu-sysemu.c
@@ -348,3 +348,65 @@ void aarch64_sync_64_to_32(CPUARMState *env)
env->regs[15] = env->pc;
}
+
+/*
+ * Return the exception level to which exceptions should be taken
+ * via SVEAccessTrap. If an exception should be routed through
+ * AArch64.AdvSIMDFPAccessTrap, return 0; fp_exception_el should
+ * take care of raising that exception.
+ * C.f. the ARM pseudocode function CheckSVEEnabled.
+ */
+int sve_exception_el(CPUARMState *env, int el)
+{
+ uint64_t hcr_el2 = arm_hcr_el2_eff(env);
+
+ if (el <= 1 && (hcr_el2 & (HCR_E2H | HCR_TGE)) != (HCR_E2H | HCR_TGE)) {
+ bool disabled = false;
+
+ /*
+ * The CPACR.ZEN controls traps to EL1:
+ * 0, 2 : trap EL0 and EL1 accesses
+ * 1 : trap only EL0 accesses
+ * 3 : trap no accesses
+ */
+ if (!extract32(env->cp15.cpacr_el1, 16, 1)) {
+ disabled = true;
+ } else if (!extract32(env->cp15.cpacr_el1, 17, 1)) {
+ disabled = el == 0;
+ }
+ if (disabled) {
+ /* route_to_el2 */
+ return hcr_el2 & HCR_TGE ? 2 : 1;
+ }
+
+ /* Check CPACR.FPEN. */
+ if (!extract32(env->cp15.cpacr_el1, 20, 1)) {
+ disabled = true;
+ } else if (!extract32(env->cp15.cpacr_el1, 21, 1)) {
+ disabled = el == 0;
+ }
+ if (disabled) {
+ return 0;
+ }
+ }
+
+ /*
+ * CPTR_EL2. Since TZ and TFP are positive,
+ * they will be zero when EL2 is not present.
+ */
+ if (el <= 2 && arm_is_el2_enabled(env)) {
+ if (env->cp15.cptr_el[2] & CPTR_TZ) {
+ return 2;
+ }
+ if (env->cp15.cptr_el[2] & CPTR_TFP) {
+ return 0;
+ }
+ }
+
+ /* CPTR_EL3. Since EZ is negative we must check for EL3. */
+ if (arm_feature(env, ARM_FEATURE_EL3)
+ && !(env->cp15.cptr_el[3] & CPTR_EZ)) {
+ return 3;
+ }
+ return 0;
+}
diff --git a/target/arm/cpu-user.c b/target/arm/cpu-user.c
index 0225089e46..39093ade76 100644
--- a/target/arm/cpu-user.c
+++ b/target/arm/cpu-user.c
@@ -33,3 +33,8 @@ uint32_t arm_phys_excp_target_el(CPUState *cs, uint32_t
excp_idx,
{
return 1;
}
+
+int sve_exception_el(CPUARMState *env, int el)
+{
+ return 0;
+}
diff --git a/target/arm/tcg/helper.c b/target/arm/tcg/helper.c
index 1c69a69d5a..8372089260 100644
--- a/target/arm/tcg/helper.c
+++ b/target/arm/tcg/helper.c
@@ -261,70 +261,6 @@ static int arm_gdb_set_svereg(CPUARMState *env, uint8_t
*buf, int reg)
}
#endif /* TARGET_AARCH64 */
-/*
- * Return the exception level to which exceptions should be taken
- * via SVEAccessTrap. If an exception should be routed through
- * AArch64.AdvSIMDFPAccessTrap, return 0; fp_exception_el should
- * take care of raising that exception.
- * C.f. the ARM pseudocode function CheckSVEEnabled.
- */
-int sve_exception_el(CPUARMState *env, int el)
-{
-#ifndef CONFIG_USER_ONLY
- uint64_t hcr_el2 = arm_hcr_el2_eff(env);
-
- if (el <= 1 && (hcr_el2 & (HCR_E2H | HCR_TGE)) != (HCR_E2H | HCR_TGE)) {
- bool disabled = false;
-
- /*
- * The CPACR.ZEN controls traps to EL1:
- * 0, 2 : trap EL0 and EL1 accesses
- * 1 : trap only EL0 accesses
- * 3 : trap no accesses
- */
- if (!extract32(env->cp15.cpacr_el1, 16, 1)) {
- disabled = true;
- } else if (!extract32(env->cp15.cpacr_el1, 17, 1)) {
- disabled = el == 0;
- }
- if (disabled) {
- /* route_to_el2 */
- return hcr_el2 & HCR_TGE ? 2 : 1;
- }
-
- /* Check CPACR.FPEN. */
- if (!extract32(env->cp15.cpacr_el1, 20, 1)) {
- disabled = true;
- } else if (!extract32(env->cp15.cpacr_el1, 21, 1)) {
- disabled = el == 0;
- }
- if (disabled) {
- return 0;
- }
- }
-
- /*
- * CPTR_EL2. Since TZ and TFP are positive,
- * they will be zero when EL2 is not present.
- */
- if (el <= 2 && arm_is_el2_enabled(env)) {
- if (env->cp15.cptr_el[2] & CPTR_TZ) {
- return 2;
- }
- if (env->cp15.cptr_el[2] & CPTR_TFP) {
- return 0;
- }
- }
-
- /* CPTR_EL3. Since EZ is negative we must check for EL3. */
- if (arm_feature(env, ARM_FEATURE_EL3)
- && !(env->cp15.cptr_el[3] & CPTR_EZ)) {
- return 3;
- }
-#endif
- return 0;
-}
-
void hw_watchpoint_update(ARMCPU *cpu, int n)
{
CPUARMState *env = &cpu->env;
--
2.20.1
- Re: [PATCH v16 74/99] target/arm: cpu-sve: make cpu_sve_finalize_features return bool, (continued)
- [PATCH v16 15/99] target/arm: move translate modules to tcg/, Alex Bennée, 2021/06/04
- [PATCH v16 50/99] target/arm: fix style of arm_cpu_do_interrupt functions before move, Alex Bennée, 2021/06/04
- [PATCH v16 54/99] target/arm: move TCGCPUOps to tcg/tcg-cpu.c, Alex Bennée, 2021/06/04
- [PATCH v16 63/99] tests/qtest: skip bios-tables-test test_acpi_oem_fields_virt for KVM, Alex Bennée, 2021/06/04
- [PATCH v16 95/99] hw/arm: add dependency on OR_IRQ for XLNX_VERSAL, Alex Bennée, 2021/06/04
- [PATCH v16 45/99] target/arm: move sve_exception_el out of TCG helpers,
Alex Bennée <=
- [PATCH v16 72/99] target/arm: cpu-sve: rename functions according to module prefix, Alex Bennée, 2021/06/04
- [PATCH v16 55/99] target/arm: move cpu_tcg to tcg/tcg-cpu-models.c, Alex Bennée, 2021/06/04
- [PATCH v16 20/99] target/arm: tcg: move sysemu-only parts of debug_helper, Alex Bennée, 2021/06/04
- [PATCH v16 46/99] target/arm: fix comments style of fp_exception_el before moving it, Alex Bennée, 2021/06/04
- [PATCH v16 37/99] target/arm: move sve_zcr_len_for_el to common_cpu, Alex Bennée, 2021/06/04
- [PATCH v16 34/99] target/arm: move arm_hcr_el2_eff from tcg/ to common_cpu, Alex Bennée, 2021/06/04
- [PATCH v16 17/99] arm: tcg: only build under CONFIG_TCG, Alex Bennée, 2021/06/04