[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 07/28] qtest: add a QOM object for qtest
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PULL 07/28] qtest: add a QOM object for qtest |
Date: |
Fri, 4 Jun 2021 17:45:41 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 |
On 6/4/21 5:37 PM, Eric Blake wrote:
> On Mon, May 24, 2021 at 06:41:10PM +0200, Paolo Bonzini wrote:
>> The qtest server right now can only be created using the -qtest
>> and -qtest-log options. Allow an alternative way to create it
>> using "-object qtest,chardev=...,log=...".
>>
>> This is part of the long term plan to make more (or all) of
>> QEMU configurable through QMP and preconfig mode.
>>
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> ---
>> qapi/qom.json | 17 +++++
>> softmmu/qtest.c | 185 +++++++++++++++++++++++++++++++++++++++++++++---
>> softmmu/vl.c | 5 +-
>> 3 files changed, 196 insertions(+), 11 deletions(-)
>>
>> diff --git a/qapi/qom.json b/qapi/qom.json
>> index 4f48035831..f7ef30f940 100644
>> --- a/qapi/qom.json
>> +++ b/qapi/qom.json
>> @@ -644,6 +644,21 @@
>> { 'struct': 'PrManagerHelperProperties',
>> 'data': { 'path': 'str' } }
>>
>> +##
>> +# @QtestProperties:
>> +#
>> +# Properties for qtest objects.
>> +#
>> +# @chardev: the chardev to be used to receive qtest commands on.
>> +#
>> +# @log: the path to a log file
>> +#
>> +# Since: 6.0
>
> Do we need a followup patch to correct this to 6.1?
This hasn't been merged, so since Paolo will repost,
maybe he can fix directly?