qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4 0/3] tests: Reorganize MIPS TCG directories a


From: Aleksandar Rikalo
Subject: Re: [Qemu-devel] [PATCH v4 0/3] tests: Reorganize MIPS TCG directories and files
Date: Fri, 4 Jun 2021 12:01:18 +0000

Hi Philippe,

>>> From: Aleksandar Markovic <amarkovic@wavecomp.com>
>>>
>>> Reorganize MIPS TCG directories and files.
>>>
>>> Directories for DSP tests in system mode are deleted. They
>>> introduce more complexity in test structure compared to the
>>> value they add. Still, these tests may be moved somewhere
>>> else, let's say in a new acceptance test that will boot
>>> "mips64r2" virtual machine.
>>>
>>> All remaining test will are user mode tests, which will
>>> simplify maintenance of mips tcg tests overall.
>>>
>>> The file movement is done using "git mv" command, so "git
>>> blame" will still display the original information, regardless
>>> of the new names and locations of involved files. Also, the
>>> command "git config diff.renames true" was used to keep the
>>> size of movement patches reasonable.

>> From: Aleksandar Rikalo <arikalo@wavecomp.com>
>>
>> I too think that this will simplify the test dirs structure and
>> maintenance. I cannot wait to see these directories populated with
>> new tests for various MIPS ISAs and ASEs.
>>
>> For all patches in this series:
>>
>> Reviewed-by: Aleksandar Rikalo <arikalo@wavecomp.com>

> From: Philippe Mathieu-Daudé <philippe.mathieu.daude@gmail.com>

> Apparently this series was a bit too enthusiastic and removed
> many tests (MIPS64 DSP r1 and r2 for example) which then got
> never reintroduced. What is your plan regarding the "new
> tests" you mentioned?

I have decided not to put any more tests for the time being.

-- Aleksandar R.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]