[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v5 12/16] qemu-iotests: allow valgrind to read/delete the generat
From: |
Emanuele Giuseppe Esposito |
Subject: |
[PATCH v5 12/16] qemu-iotests: allow valgrind to read/delete the generated log file |
Date: |
Fri, 4 Jun 2021 11:17:19 +0200 |
When using --valgrind on the script tests, it generates a log file
in $TEST_DIR that is either read (if valgrind finds problems) or
otherwise deleted. Provide the same exact behavior when using
--valgrind on the python tests.
Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
tests/qemu-iotests/iotests.py | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
index e4a299b9f3..89099c13e6 100644
--- a/tests/qemu-iotests/iotests.py
+++ b/tests/qemu-iotests/iotests.py
@@ -601,6 +601,17 @@ def __init__(self, path_suffix=''):
sock_dir=sock_dir, qmp_timer=timer)
self._num_drives = 0
+ def _post_shutdown(self) -> None:
+ super()._post_shutdown()
+ if not qemu_valgrind or not self._popen:
+ return
+ valgrind_filename = f"{test_dir}/{self._popen.pid}.valgrind"
+ if self.exitcode() == 99:
+ with open(valgrind_filename) as f:
+ print(f.read())
+ else:
+ os.remove(valgrind_filename)
+
def add_object(self, opts):
self._args.append('-object')
self._args.append(opts)
--
2.30.2
- Re: [PATCH v5 06/16] qemu-iotests: delay QMP socket timers, (continued)
- [PATCH v5 09/16] docs/devel/testing: add --gdb option to the debugging section of QEMU iotests, Emanuele Giuseppe Esposito, 2021/06/04
- [PATCH v5 11/16] qemu-iotests: extend QMP socket timeout when using valgrind, Emanuele Giuseppe Esposito, 2021/06/04
- [PATCH v5 12/16] qemu-iotests: allow valgrind to read/delete the generated log file,
Emanuele Giuseppe Esposito <=
- [PATCH v5 13/16] qemu-iotests: insert valgrind command line as wrapper for qemu binary, Emanuele Giuseppe Esposito, 2021/06/04
- [PATCH v5 14/16] docs/devel/testing: add --valgrind option to the debug section of QEMU iotests, Emanuele Giuseppe Esposito, 2021/06/04
- [PATCH v5 15/16] qemu-iotests: add option to show qemu binary logs on stdout, Emanuele Giuseppe Esposito, 2021/06/04
- [PATCH v5 16/16] docs/devel/testing: add -p option to the debug section of QEMU iotests, Emanuele Giuseppe Esposito, 2021/06/04
- Re: [PATCH v5 00/16] qemu_iotests: improve debugging options, Emanuele Giuseppe Esposito, 2021/06/14