Re: [PATCH 01/11] hw/char: Renesas SCI module.

[Peter Maydell]

On Thu, 27 May 2021 at 06:30, Yoshinori Sato <ysato@users.sourceforge.jp> wrote:
>
> This module supported SCI / SCIa / SCIF.
>
> Hardware manual.
> SCI / SCIF
> https://www.renesas.com/us/en/doc/products/mpumcu/001/r01uh0457ej0401_sh7751.pdf
> SCIa
> https://www.renesas.com/us/en/doc/products/mpumcu/doc/rx_family/r01uh0033ej0140_rx62n.pdf
>
> Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
> ---
>  include/hw/char/renesas_sci.h |  129 +++-
>  hw/char/renesas_sci.c         | 1039 +++++++++++++++++++++++++++------
>  2 files changed, 966 insertions(+), 202 deletions(-)

This patch is much too large to review. Could you split it up into
multiple logical pieces, please?

>
> diff --git a/include/hw/char/renesas_sci.h b/include/hw/char/renesas_sci.h
> index a4764e3eee..ae9554db60 100644
> --- a/include/hw/char/renesas_sci.h
> +++ b/include/hw/char/renesas_sci.h
> @@ -1,54 +1,137 @@
>  /*
>   * Renesas Serial Communication Interface
>   *
> - * Copyright (c) 2018 Yoshinori Sato
> + * Copyright (c) 2020 Yoshinori Sato
> + *
> + * This code is licensed under the GPL version 2 or later.
>   *
> - * SPDX-License-Identifier: GPL-2.0-or-later

Did you have a reason for deleting the SPDX line ?

>   */
>
> -#ifndef HW_CHAR_RENESAS_SCI_H
> -#define HW_CHAR_RENESAS_SCI_H
> -

Why have you deleted the multiple-include guard?

thanks
-- PMM