[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 41/45] tests/qtest/e1000e-test: Check qemu_recv() succeeded
From: |
Peter Maydell |
Subject: |
[PULL 41/45] tests/qtest/e1000e-test: Check qemu_recv() succeeded |
Date: |
Thu, 3 Jun 2021 16:59:00 +0100 |
The e1000e_send_verify() test calls qemu_recv() but doesn't
check that the call succeeded, which annoys Coverity. Add
an explicit test check for the length of the data.
(This is a test check, not a "we assume this syscall always
succeeds", so we use g_assert_cmpint() rather than g_assert().)
Fixes: Coverity CID 1432324
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>
Message-id: 20210525134458.6675-3-peter.maydell@linaro.org
---
tests/qtest/e1000e-test.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/qtest/e1000e-test.c b/tests/qtest/e1000e-test.c
index fc226fdfeb5..0273fe4c156 100644
--- a/tests/qtest/e1000e-test.c
+++ b/tests/qtest/e1000e-test.c
@@ -93,7 +93,8 @@ static void e1000e_send_verify(QE1000E *d, int *test_sockets,
QGuestAllocator *a
/* Check data sent to the backend */
ret = qemu_recv(test_sockets[0], &recv_len, sizeof(recv_len), 0);
g_assert_cmpint(ret, == , sizeof(recv_len));
- qemu_recv(test_sockets[0], buffer, 64, 0);
+ ret = qemu_recv(test_sockets[0], buffer, 64, 0);
+ g_assert_cmpint(ret, >=, 5);
g_assert_cmpstr(buffer, == , "TEST");
/* Free test data buffer */
--
2.20.1
- [PULL 31/45] hvf: Move hvf internal definitions into common header, (continued)
- [PULL 31/45] hvf: Move hvf internal definitions into common header, Peter Maydell, 2021/06/03
- [PULL 33/45] hvf: Remove use of hv_uvaddr_t and hv_gpaddr_t, Peter Maydell, 2021/06/03
- [PULL 34/45] hvf: Split out common code on vcpu init and destroy, Peter Maydell, 2021/06/03
- [PULL 35/45] hvf: Use cpu_synchronize_state(), Peter Maydell, 2021/06/03
- [PULL 37/45] hvf: Remove hvf-accel-ops.h, Peter Maydell, 2021/06/03
- [PULL 36/45] hvf: Make synchronize functions static, Peter Maydell, 2021/06/03
- [PULL 32/45] hvf: Make hvf_set_phys_mem() static, Peter Maydell, 2021/06/03
- [PULL 39/45] hvf: Simplify post reset/init/loadvm hooks, Peter Maydell, 2021/06/03
- [PULL 40/45] tests/qtest/bios-tables-test: Check for dup2() failure, Peter Maydell, 2021/06/03
- [PULL 44/45] tests/qtest/tpm-tests: Remove unnecessary NULL checks, Peter Maydell, 2021/06/03
- [PULL 41/45] tests/qtest/e1000e-test: Check qemu_recv() succeeded,
Peter Maydell <=
- [PULL 38/45] hvf: Introduce hvf vcpu struct, Peter Maydell, 2021/06/03
- [PULL 42/45] tests/qtest/hd-geo-test: Fix checks on mkstemp() return value, Peter Maydell, 2021/06/03
- [PULL 43/45] tests/qtest/pflash-cfi02-test: Avoid potential integer overflow, Peter Maydell, 2021/06/03
- [PULL 45/45] tests/unit/test-vmstate: Assert that dup() and mkstemp() succeed, Peter Maydell, 2021/06/03
- Re: [PULL 00/45] target-arm queue, no-reply, 2021/06/03
- Re: [PULL 00/45] target-arm queue, Peter Maydell, 2021/06/03