Re: [PATCH v3 02/19] python/qmp: Fix type of SocketAddrT

[Philippe Mathieu-Daudé]

On 6/3/21 2:37 AM, John Snow wrote:
> In porting the qom tools, qmp-shell, etc; it becomes evident that this
> type is wrong.
> 
> This is an integer, not a string. We didn't catch this before because
> none of QEMUMonitorProtocol's *users* happen to be checked, and the
> internal logic of this class is otherwise self-consistent. Additionally,
> mypy was not introspecting into the socket() interface to realize we
> were passing a bad type for AF_INET. Fixed now.
> 
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>  python/qemu/qmp/__init__.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>