[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 13/19] scripts/qom-fuse: use QOMCommand.qom_list()
From: |
John Snow |
Subject: |
[PATCH v3 13/19] scripts/qom-fuse: use QOMCommand.qom_list() |
Date: |
Wed, 2 Jun 2021 20:37:13 -0400 |
the qom_list method provides a type-safe object that's easier to type
check, so switch to using it.
Signed-off-by: John Snow <jsnow@redhat.com>
---
scripts/qmp/qom-fuse | 18 ++++++++----------
1 file changed, 8 insertions(+), 10 deletions(-)
diff --git a/scripts/qmp/qom-fuse b/scripts/qmp/qom-fuse
index 1676fb78d99..703a97e75ff 100755
--- a/scripts/qmp/qom-fuse
+++ b/scripts/qmp/qom-fuse
@@ -94,7 +94,7 @@ class QOMFuse(QOMCommand, Operations):
def is_object(self, path):
"""Is the given QOM path an object?"""
try:
- self.qmp.command('qom-list', path=path)
+ self.qom_list(path)
return True
except QMPResponseError:
return False
@@ -105,8 +105,8 @@ class QOMFuse(QOMCommand, Operations):
if path == '':
path = '/'
try:
- for item in self.qmp.command('qom-list', path=path):
- if item['name'] == prop:
+ for item in self.qom_list(path):
+ if item.name == prop:
return True
return False
except QMPResponseError:
@@ -118,11 +118,9 @@ class QOMFuse(QOMCommand, Operations):
if path == '':
path = '/'
try:
- for item in self.qmp.command('qom-list', path=path):
- if item['name'] == prop:
- if item['type'].startswith('link<'):
- return True
- return False
+ for item in self.qom_list(path):
+ if item.name == prop and item.link:
+ return True
return False
except QMPResponseError:
return False
@@ -200,8 +198,8 @@ class QOMFuse(QOMCommand, Operations):
def readdir(self, path, fh):
yield '.'
yield '..'
- for item in self.qmp.command('qom-list', path=path):
- yield str(item['name'])
+ for item in self.qom_list(path):
+ yield item.name
if __name__ == '__main__':
--
2.31.1
- [PATCH v3 05/19] python/qmp: add qom script entry points, (continued)
- [PATCH v3 05/19] python/qmp: add qom script entry points, John Snow, 2021/06/02
- [PATCH v3 04/19] python/qmp: Add qom script rewrites, John Snow, 2021/06/02
- [PATCH v3 06/19] scripts/qmp: redirect qom-xxx scripts to python/qemu/qmp/, John Snow, 2021/06/02
- [PATCH v3 07/19] scripts/qom-fuse: apply isort rules, John Snow, 2021/06/02
- [PATCH v3 08/19] scripts/qom-fuse: apply flake8 rules, John Snow, 2021/06/02
- [PATCH v3 09/19] python: Add 'fh' to known-good variable names, John Snow, 2021/06/02
- [PATCH v3 10/19] scripts/qom-fuse: Apply pylint rules, John Snow, 2021/06/02
- [PATCH v3 11/19] scripts/qom-fuse: Add docstrings, John Snow, 2021/06/02
- [PATCH v3 12/19] scripts/qom-fuse: Convert to QOMCommand, John Snow, 2021/06/02
- [PATCH v3 13/19] scripts/qom-fuse: use QOMCommand.qom_list(),
John Snow <=
- [PATCH v3 14/19] scripts/qom-fuse: ensure QOMFuse.read always returns bytes, John Snow, 2021/06/02
- [PATCH v3 15/19] scripts/qom-fuse: add static type hints, John Snow, 2021/06/02
- [PATCH v3 16/19] python: add optional FUSE dependencies, John Snow, 2021/06/02
- [PATCH v3 17/19] scripts/qom-fuse: move to python/qemu/qmp/qom_fuse.py, John Snow, 2021/06/02
- [PATCH v3 19/19] python/qmp: add fuse command to 'qom' tools, John Snow, 2021/06/02
- [PATCH v3 18/19] scripts/qom-fuse: add redirection shim to python/qemu/qmp/qom-fuse.py, John Snow, 2021/06/02
- Re: [PATCH v3 00/19] Python: move /scripts/qmp/qom* to /python/qemu/qmp/qom*, John Snow, 2021/06/09