Re: [PATCH v2 03/28] softfloat: Move uint_to_float to softfloat-parts.c.inc

[Richard Henderson]

On 6/2/21 4:31 AM, Alex Bennée wrote:
> > +        scale = MIN(MAX(scale, -0x10000), 0x10000);
>
> here but it does seem weird to have an arbitrary limit here
>
> > +        p->cls = float_class_normal;
> > +        p->exp = DECOMPOSED_BINARY_POINT - shift + scale;
>
> where it's really a limit on fmt->exp_max. Are we just limiting it to
> something sane and relying on the eventual repack to detect and overflow
> condition?

Yep.  This is before and after, mind.

r~