Re: [RFC v4 11/14] target/s390x: remove kvm-stub.c

[Thomas Huth]

On 02/06/2021 12.44, Cornelia Huck wrote:
> On Mon, May 24 2021, "Cho, Yu-Chen" <acho@suse.com> wrote:
>
> > all function calls are protected by kvm_enabled(),
> > so we should not need the stubs.
> >
> > Signed-off-by: Claudio Fontana <cfontana@suse.de>
> > Signed-off-by: Cho, Yu-Chen <acho@suse.com>
> > ---
> >   target/s390x/kvm-stub.c  | 126 ---------------------------------------
> >   target/s390x/meson.build |   2 +-
> >   2 files changed, 1 insertion(+), 127 deletions(-)
> >   delete mode 100644 target/s390x/kvm-stub.c
>
> (...)
>
> > -int kvm_s390_get_gs(void)
> > -{
> > -    return 0;
> > -}
>
> Unrelated to this patch: Nobody seems to call kvm_s390_get_gs()
> (anymore?); are we missing something, or can that function be removed?

The last user has likely been removed with 0280b3eb7c0519b43452 ("s390x/kvm: 
use cpu model for gscb on compat machines"). I think this could be removed now.

 Thomas