Re: [RFC v4 08/14] target/s390x: split cpu-dump from helper.c

[Cornelia Huck]

On Mon, May 24 2021, "Cho, Yu-Chen" <acho@suse.com> wrote:

Please add a line as to *why* you are splitting this off; that is not
clear if you look at this change individually.

> Signed-off-by: Claudio Fontana <cfontana@suse.de>
> Signed-off-by: Cho, Yu-Chen <acho@suse.com>
> ---
>  target/s390x/cpu-dump.c  | 131 +++++++++++++++++++++++++++++++++++++++
>  target/s390x/helper.c    | 107 --------------------------------
>  target/s390x/meson.build |   1 +
>  3 files changed, 132 insertions(+), 107 deletions(-)
>  create mode 100644 target/s390x/cpu-dump.c
>
> diff --git a/target/s390x/cpu-dump.c b/target/s390x/cpu-dump.c
> new file mode 100644

Not sure whether this is worth an entire new file; but it does not hurt,
either. Generally, looks sane.

Acked-by: Cornelia Huck <cohuck@redhat.com>