Re: [PATCH v1 2/6] KVM: introduce dirty_pages into CPUState

[Hyman Huang]

在 2021/6/2 7:20, Peter Xu 写道:
> On Tue, Jun 01, 2021 at 01:04:06AM +0800, huangy81@chinatelecom.cn wrote:
> > diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h
> > index 044f668a6e..973c193501 100644
> > --- a/include/hw/core/cpu.h
> > +++ b/include/hw/core/cpu.h
> > @@ -375,6 +375,8 @@ struct CPUState {
> >       struct kvm_run *kvm_run;
> >       struct kvm_dirty_gfn *kvm_dirty_gfns;
> >       uint32_t kvm_fetch_index;
> > +    uint64_t dirty_pages;
> > +    bool stat_dirty_pages;
>
> Shall we make this bool a global one?  As I don't think we'll be able to only
> enable it on a subset of cpus?
Yes, it's a reasonable advice, i'll apply this on the next version
>

--
Best regard

Hyman Huang(黄勇)