Re: [PATCH v2 1/2] hw/nvme: add support for boot partiotions

[Klaus Jensen]

On Jun  1 19:41, Klaus Jensen wrote:
> On Jun  1 10:19, Keith Busch wrote:
> > On Tue, Jun 01, 2021 at 08:07:48PM +0530, Gollu Appalanaidu wrote:
> > > NVMe Boot Partitions provides an area that may be read by the host
> > > without initializing queues or even enabling the controller. This
> > > allows various platform initialization code to be stored on the NVMe
> > > device instead of some separete medium.
> > >
> > > This patch adds the read support for such an area, as well as support
> > > for updating the boot partition contents from the host through the
> > > FW Download and Commit commands.
> >
> > Please provide some details on what platform initilization sequence
> > running on QEMU is going to make use of this feature.
>
> I totally get your reluctance to accept useless features like device 
> self-test and ill-supported ones like write uncorrectable.
>
> But I think this feature qualifies just fine for the device. It is 
> useful for embedded development and while there might not be any qemu 
> boards that wants to use this *right now*, it allows for 
> experimentation. And this is a feature that actually *is* implemented 
> by real products for embedded systems.

And while the test-case does need more work, there actually *is* a test 
accompanying this. That's a higher standard than 98% of the features we 
have in this device :P

signature.asc
Description: PGP signature