qemu-devel
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v6 11/26] tcg/tci: Use ffi for calls

From: Richard Henderson
Subject: Re: [PATCH v6 11/26] tcg/tci: Use ffi for calls
Date: Tue, 1 Jun 2021 07:38:16 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 
On 5/31/21 10:18 PM, Philippe Mathieu-Daudé wrote:

  /* Used for function call generation. */
  #define TCG_TARGET_CALL_STACK_OFFSET    0
-#define TCG_TARGET_STACK_ALIGN          16
+#define TCG_TARGET_STACK_ALIGN          8


Is this FFI_SIZEOF_ARG?


No, just uint64_t.


+    call_slots[0] = NULL;


Maybe add a comment "Other slots initialization delayed (see below)"?


Sure.

r~
reply via email to
[Prev in Thread] Current Thread [Next in Thread]