Re: [PATCH] target/nios2: Mark raise_exception() as noreturn

[Richard Henderson]

On 5/31/21 2:30 AM, Philippe Mathieu-Daudé wrote:
> Raised exceptions don't return, so mark the helper with
> TCG_CALL_NO_RETURN.
>
> Fixes: 032c76bc6f9 ("nios2: Add architecture emulation support")
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>   target/nios2/helper.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/nios2/helper.h b/target/nios2/helper.h
> index b0cb9146a5f..9bf14c128ed 100644
> --- a/target/nios2/helper.h
> +++ b/target/nios2/helper.h
> @@ -18,7 +18,7 @@
>    * <http://www.gnu.org/licenses/lgpl-2.1.html>
>    */
>   
> -DEF_HELPER_2(raise_exception, void, env, i32)
> +DEF_HELPER_FLAGS_2(raise_exception, TCG_CALL_NO_RETURN, noreturn, env, i32)

The noreturn is what you want for that.
For the flags, you probably want TCG_CALL_NO_WG.

>   
>   #if !defined(CONFIG_USER_ONLY)
>   DEF_HELPER_2(mmu_read_debug, void, env, i32)