RE: [PATCH v2] docs/devel: Explain in more detail the TB chaining mechanisms

[Luis Fernando Fujita Pires]

From: Bruno Piazera Larsen <bruno.larsen@eldorado.org.br> 
> I feel like there is either a comma missing or the paragraph can be reordered 
> a bit here. The way it is written means that there are many cases where the 
> TB is already available and you'll be explaining how the handle the most 
> common of such cases, but by changing the first line to
> -In order to accelerate the most common cases where the TB for the new
> +In order to accelerate the most common cases, where the TB for the new
> You get many cases, the most common of which is the TB being already in 
> memory. This sounds to me like the more reasonable, but incorrect, read of 
> the paragraph. If I am mistaken and there are indeed many cases where the TB 
> is already in memory, I think maybe it can be reordered to make this read 
> less likely to happen, by saying something like:
> QEMU has mechanisms that allow multiple TBs to be chained directly (without 
> having to go back to the main loop described above) that can accelerate the 
> most common cases of the TB for the new simulated PC already being available.

I'll just drop the bit about being the most common case, as it's irrelevant.

> This last paragraph is a bit tough to read, but I don't know a better way to 
> write it, so it may just be that this 3rd step is a bit confusing at first. 
> Maybe something like:
> -This is important because that's the TB that will have to be patched
> -by the main loop, and not necessarily the one that was directly
> -executed from it. This is due to the fact that the original TB might
> -have already been chained to additional TBs, which ended up being
> -executed without the main loop's knowledge.
> +This address corresponds to the TB that will be patched; it may be
> +different than the one that was just executed if the latter has already
> +been chained to other TBs.

That wouldn't be accurate. The returned address IS the address of the TB that 
was just executed. But the way you wrote is more direct. I'll send a new 
version of the patch that incorporates it with a few adjustments.

--
Luis Pires
Instituto de Pesquisas ELDORADO
Aviso Legal - Disclaimer <https://www.eldorado.org.br/disclaimer.html>