Re: [PATCH v2 24/33] python/qemu/machine: QEMUMachine: improve qmp() method

[Max Reitz]

On 20.05.21 16:21, Vladimir Sementsov-Ogievskiy wrote:
> We often call qmp() with unpacking dict, like qmp('foo', **{...}).
> mypy don't really like it, it things that passed unpacked dict is a

s/things/thinks/

> positional argument and complains that it type should be bool (because
> second argument of qmp() is conv_keys: bool).

I guess it would have been nice to see some examples of this that can 
now be written in a cleaner way, but well.

> Allow possing dict directly, simplifying interface, and giving a way to

s/possing/passing/

> satisfy mypy.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
>   python/qemu/machine.py | 12 +++++++++++-
>   1 file changed, 11 insertions(+), 1 deletion(-)

Reviewed-by: Max Reitz <mreitz@redhat.com>