[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 0/3] block: drop BlockDriverState::read_only
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
[PATCH v2 0/3] block: drop BlockDriverState::read_only |
Date: |
Thu, 27 May 2021 18:40:53 +0300 |
Hi all!
The field duplicates information in .open_flags. We have to carefully
sync these two fields everywhere. It's simple to introduce a bug by
forgetting it.
Let's drop the field, and fix users to call bdrv_is_read_only() and
bdrv_is_writable() instead.
v2:
01: write "update_header =\n..." in one line
03: only change BlockBackendRootState, don't touch side logic
Vladimir Sementsov-Ogievskiy (3):
block: consistently use bdrv_is_read_only()
block: drop BlockDriverState::read_only
block: drop BlockBackendRootState::read_only
include/block/block_int.h | 2 --
block.c | 16 +++++++---------
block/block-backend.c | 10 ++--------
block/commit.c | 2 +-
block/io.c | 4 ++--
block/qapi.c | 2 +-
block/qcow2-snapshot.c | 2 +-
block/qcow2.c | 5 ++---
block/snapshot.c | 2 +-
block/vhdx-log.c | 2 +-
blockdev.c | 3 +--
tests/unit/test-block-iothread.c | 6 ------
12 files changed, 19 insertions(+), 37 deletions(-)
--
2.29.2
- [PATCH v2 0/3] block: drop BlockDriverState::read_only,
Vladimir Sementsov-Ogievskiy <=