Re: [PULL 1/3] hw/net/imx_fec: return 0xffff when accessing non-existing PHY

[Jason Wang]

在 2021/5/26 下午5:08, Philippe Mathieu-Daudé 写道:
> On 5/26/21 10:24 AM, Jason Wang wrote:
> > From: Guenter Roeck <linux@roeck-us.net>
> >
> > If a PHY does not exist, attempts to read from it should return 0xffff.
> > Otherwise the Linux kernel will believe that a PHY is there and select
> > the non-existing PHY. This in turn will result in network errors later
> > on since the real PHY is not selected or configured.
> >
> > Since reading from or writing to a non-existing PHY is not an emulation
> > error, replace guest error messages with traces.
> >
> > Fixes: 461c51ad4275 ("Add a phy-num property to the i.MX FEC emulator")
> > Cc: Jean-Christophe Dubois <jcd@tribudubois.net>
> > Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
> > Tested-by: Bin Meng <bmeng.cn@gmail.com>
> > Reviewed-by: Philippe Mathieu-Daud茅 <f4bug@amsat.org>
> Mojibake :/


My bad, v2 sent.

Thanks


> > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> > Signed-off-by: Jason Wang <jasowang@redhat.com>
> > ---
> >   hw/net/imx_fec.c    | 8 +++-----
> >   hw/net/trace-events | 2 ++
> >   2 files changed, 5 insertions(+), 5 deletions(-)