qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC PATCH 11/15] exec/cpu: Make address_space_init/reloading_memory


From: Richard Henderson
Subject: Re: [RFC PATCH 11/15] exec/cpu: Make address_space_init/reloading_memory_map target agnostic
Date: Wed, 26 May 2021 12:01:14 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1

On 5/17/21 4:55 AM, Philippe Mathieu-Daudé wrote:
cpu_address_space_init() and cpu_reloading_memory_map() don't
have to be target specific. Remove this limitation to be able
to build softmmu/cpus.c once for all targets.

Signed-off-by: Philippe Mathieu-Daudé<f4bug@amsat.org>
---
  include/exec/cpu-common.h | 23 +++++++++++++++++++++++
  include/exec/exec-all.h   | 25 -------------------------
  2 files changed, 23 insertions(+), 25 deletions(-)

It's not clear to me why the declarations moved file, instead of just droppig the surrounding ifdef.

If there's a good reason, fine, but the reason belongs in the commit message.

r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]