qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v6 03/13] virtio-gpu: Add udmabuf helpers


From: Gerd Hoffmann
Subject: Re: [PATCH v6 03/13] virtio-gpu: Add udmabuf helpers
Date: Wed, 26 May 2021 08:16:33 +0200

  Hi,

> +#ifdef CONFIG_LINUX

Seems wee need "#if defined(CONFIG_LINUX) && defined(F_GET_SEALS)" here
to cover old linux versions.  I see some build failures in gitlab CI due to
F_GET_SEALS not being defined (crypto-old-nettle for example).

> +#include <sys/fcntl.h>

gitlab ci (build-system-alpine):

/usr/include/sys/fcntl.h:1:2: error: #warning redirecting incorrect #include 
<sys/fcntl.h> to <fcntl.h> [-Werror=cpp]
    1 | #warning redirecting incorrect #include <sys/fcntl.h> to <fcntl.h>

Otherwise series looks good and survived basic testing.

take care,
  Gerd




reply via email to

[Prev in Thread] Current Thread [Next in Thread]