Re: [PATCH v7 02/23] cpu: Restrict target cpu_do_transaction_failed() handlers to sysemu

[Richard Henderson]

On 5/17/21 3:51 AM, Philippe Mathieu-Daudé wrote:
> In commit cbc183d2d9f ("cpu: move cc->transaction_failed to tcg_ops")
> we restricted the do_transaction_failed() handler to the sysemu part
> of TCGCPUOps, but forgot to restrict the target specific declarations.
>
> Signed-off-by: Philippe Mathieu-Daudé<f4bug@amsat.org>
> ---
>   target/arm/internals.h |  2 ++
>   target/m68k/cpu.h      |  2 ++
>   target/riscv/cpu.h     | 10 +++++-----
>   target/xtensa/cpu.h    |  8 ++++----
>   4 files changed, 13 insertions(+), 9 deletions(-)

What do the extra ifdefs buy us? Surely the fact that the symbol is not present 
in the user-only, and would produce link errors if used, is sufficient?

r~