[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 25/25] python: add tox support
From: |
Cleber Rosa |
Subject: |
Re: [PATCH v6 25/25] python: add tox support |
Date: |
Tue, 25 May 2021 16:15:04 -0400 |
On Wed, May 12, 2021 at 07:12:41PM -0400, John Snow wrote:
> This is intended to be a manually run, non-CI script.
>
> Use tox to test the linters against all python versions from 3.6 to
> 3.9. This will only work if you actually have those versions installed
> locally, but Fedora makes this easy:
>
> > sudo dnf install python36 python37 python38 python39
>
> Unlike the pipenv tests (make venv-check), this pulls "whichever"
> versions of the python packages, so they are unpinned and may break as
> time goes on. In the case that breakages are found, setup.cfg should be
> amended accordingly to avoid the bad dependant versions, or the code
> should be amended to work around the issue.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> python/README.rst | 2 ++
> python/.gitignore | 1 +
> python/Makefile | 7 ++++++-
> python/setup.cfg | 1 +
> python/tox.ini | 13 +++++++++++++
> 5 files changed, 23 insertions(+), 1 deletion(-)
> create mode 100644 python/tox.ini
>
This works as intended for me. A couple of notes / suggestions
for future improvements:
* `dnf install tox` pulled all the Python versions available (I
assume as suggestions) automatically
* tox.ini can be folded into setup.cfg
* a custom container image with all those Python versions may be
handy for running both the pipenv based job (along with the
suggestions on the previous patch) and an on-demand,
"allow_failure" tox based CI job.
Other than those suggestions, this LGTM!
Reviewed-by: Cleber Rosa <crosa@redhat.com>
Tested-by: Cleber Rosa <crosa@redhat.com>
signature.asc
Description: PGP signature
- Re: [PATCH v6 22/25] python: add Makefile for some common tasks, (continued)
[PATCH v6 23/25] python: add .gitignore, John Snow, 2021/05/12
[PATCH v6 24/25] gitlab: add python linters to CI, John Snow, 2021/05/12
[PATCH v6 25/25] python: add tox support, John Snow, 2021/05/12
- Re: [PATCH v6 25/25] python: add tox support,
Cleber Rosa <=
Re: [PATCH v6 00/25] python: create installable package, John Snow, 2021/05/17