[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 6/7] gdbstub: tidy away reverse debugging check into function
From: |
Alex Bennée |
Subject: |
[PULL 6/7] gdbstub: tidy away reverse debugging check into function |
Date: |
Tue, 25 May 2021 12:24:30 +0100 |
In theory we don't need an actual record/replay to enact reverse
debugging on a purely deterministic system (i.e one with no external
inputs running under icount). Tidy away the logic into a little
function.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20210520174303.12310-8-alex.bennee@linaro.org>
diff --git a/gdbstub.c b/gdbstub.c
index 84ce770a04..52bde5bdc9 100644
--- a/gdbstub.c
+++ b/gdbstub.c
@@ -465,6 +465,15 @@ int use_gdb_syscalls(void)
return gdb_syscall_mode == GDB_SYS_ENABLED;
}
+static bool stub_can_reverse(void)
+{
+#ifdef CONFIG_USER_ONLY
+ return false;
+#else
+ return replay_mode == REPLAY_MODE_PLAY;
+#endif
+}
+
/* Resume execution. */
static inline void gdb_continue(void)
{
@@ -1880,7 +1889,7 @@ static void handle_step(GArray *params, void *user_ctx)
static void handle_backward(GArray *params, void *user_ctx)
{
- if (replay_mode != REPLAY_MODE_PLAY) {
+ if (!stub_can_reverse()) {
put_packet("E22");
}
if (params->len == 1) {
@@ -2153,7 +2162,7 @@ static void handle_query_supported(GArray *params, void
*user_ctx)
g_string_append(gdbserver_state.str_buf, ";qXfer:features:read+");
}
- if (replay_mode == REPLAY_MODE_PLAY) {
+ if (stub_can_reverse()) {
g_string_append(gdbserver_state.str_buf,
";ReverseStep+;ReverseContinue+");
}
--
2.20.1
- [PULL 0/7] testing, gdbstub and plugin updates, Alex Bennée, 2021/05/25
- [PULL 1/7] gitlab: explicitly reference the upstream registry, Alex Bennée, 2021/05/25
- [PULL 2/7] gitlab: add special rule for the hexagon container, Alex Bennée, 2021/05/25
- [PULL 3/7] gdbstub: Constify GdbCmdParseEntry, Alex Bennée, 2021/05/25
- [PULL 5/7] hmp-commands: expand type of icount to "l" in replay commands, Alex Bennée, 2021/05/25
- [PULL 4/7] gdbstub: Replace GdbCmdContext with plain g_array(), Alex Bennée, 2021/05/25
- [PULL 6/7] gdbstub: tidy away reverse debugging check into function,
Alex Bennée <=
- [PULL 7/7] plugins/syscall: Added a table-like summary output, Alex Bennée, 2021/05/25
- Re: [PULL 0/7] testing, gdbstub and plugin updates, Philippe Mathieu-Daudé, 2021/05/25
- Re: [PULL 0/7] testing, gdbstub and plugin updates, Peter Maydell, 2021/05/25