[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 4/9] target/ppc: overhauled and moved logic of storing fps
|
From: |
David Gibson |
|
Subject: |
Re: [PATCH v3 4/9] target/ppc: overhauled and moved logic of storing fpscr |
|
Date: |
Tue, 25 May 2021 13:15:41 +1000 |
On Mon, May 24, 2021 at 07:01:20PM -0700, Richard Henderson wrote:
> On 5/21/21 1:17 PM, Bruno Larsen (billionai) wrote:
> > + uint32_t mask = 1u << bit;
> > + if (env->fpscr & mask) {
> > + ppc_store_fpscr(env, env->fpscr & ~mask);
>
> Oops, missed this during review but:
>
> fpscr & ~(target_ulong)mask;
>
> Otherwise we clear high bits of fpscr incorrectly.
Oops, good point. I've removed the previous version from ppc-for-6.1,
and I'll wait for a respin.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
- [PATCH v3 0/9] target/ppc: add support to disable-tcg, Bruno Larsen (billionai), 2021/05/21
- [PATCH v3 1/9] target/ppc: cleaned error_report from ppc_store_sdr1, Bruno Larsen (billionai), 2021/05/21
- [PATCH v3 2/9] target/ppc: moved ppc_store_lpcr and ppc_store_msr to cpu.c, Bruno Larsen (billionai), 2021/05/21
- [PATCH v3 3/9] target/ppc: reduce usage of fpscr_set_rounding_mode, Bruno Larsen (billionai), 2021/05/21
- [PATCH v3 4/9] target/ppc: overhauled and moved logic of storing fpscr, Bruno Larsen (billionai), 2021/05/21
- [PATCH v3 5/9] target/ppc: removed unnecessary inclusion of helper-proto.h, Bruno Larsen (billionai), 2021/05/21
- [PATCH v3 6/9] target/ppc: moved ppc_cpu_do_interrupt to cpu.c, Bruno Larsen (billionai), 2021/05/21
- [PATCH v3 7/9] target/ppc: Added options to disable many TCG-only functions, Bruno Larsen (billionai), 2021/05/21
- [PATCH v3 8/9] target/ppc: created tcg-stub.c file, Bruno Larsen (billionai), 2021/05/21