[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v7 86/92] target/arm: Fix decode for VDOT (indexed)
From: |
Richard Henderson |
Subject: |
[PATCH v7 86/92] target/arm: Fix decode for VDOT (indexed) |
Date: |
Mon, 24 May 2021 18:03:52 -0700 |
We were extracting the M register twice, once incorrectly
as M:vm and once correctly as rm. Remove the incorrect
name and remove the incorrect decode.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/neon-shared.decode | 4 ++--
target/arm/translate-neon.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/target/arm/neon-shared.decode b/target/arm/neon-shared.decode
index ca0c699072..facb621450 100644
--- a/target/arm/neon-shared.decode
+++ b/target/arm/neon-shared.decode
@@ -61,8 +61,8 @@ VCMLA_scalar 1111 1110 0 . rot:2 .... .... 1000 . q:1
index:1 0 vm:4 \
VCMLA_scalar 1111 1110 1 . rot:2 .... .... 1000 . q:1 . 0 .... \
vm=%vm_dp vn=%vn_dp vd=%vd_dp size=2 index=0
-VDOT_scalar 1111 1110 0 . 10 .... .... 1101 . q:1 index:1 u:1 rm:4 \
- vm=%vm_dp vn=%vn_dp vd=%vd_dp
+VDOT_scalar 1111 1110 0 . 10 .... .... 1101 . q:1 index:1 u:1 vm:4 \
+ vn=%vn_dp vd=%vd_dp
%vfml_scalar_q0_rm 0:3 5:1
%vfml_scalar_q1_index 5:1 3:1
diff --git a/target/arm/translate-neon.c b/target/arm/translate-neon.c
index 14a9d0d4d3..9f7a88aab1 100644
--- a/target/arm/translate-neon.c
+++ b/target/arm/translate-neon.c
@@ -348,7 +348,7 @@ static bool trans_VDOT_scalar(DisasContext *s,
arg_VDOT_scalar *a)
opr_sz = (1 + a->q) * 8;
tcg_gen_gvec_4_ool(vfp_reg_offset(1, a->vd),
vfp_reg_offset(1, a->vn),
- vfp_reg_offset(1, a->rm),
+ vfp_reg_offset(1, a->vm),
vfp_reg_offset(1, a->vd),
opr_sz, opr_sz, a->index, fn_gvec);
return true;
--
2.25.1
- [PATCH v7 78/92] target/arm: Implement SVE2 LD1RO, (continued)
- [PATCH v7 78/92] target/arm: Implement SVE2 LD1RO, Richard Henderson, 2021/05/24
- [PATCH v7 82/92] target/arm: Implement SVE2 fp multiply-add long, Richard Henderson, 2021/05/24
- [PATCH v7 80/92] target/arm: Implement SVE2 bitwise shift immediate, Richard Henderson, 2021/05/24
- [PATCH v7 81/92] target/arm: Move endian adjustment macros to vec_internal.h, Richard Henderson, 2021/05/24
- [PATCH v7 83/92] target/arm: Implement aarch64 SUDOT, USDOT, Richard Henderson, 2021/05/24
- [PATCH v7 85/92] target/arm: Remove unused fpst from VDOT_scalar, Richard Henderson, 2021/05/24
- [PATCH v7 87/92] target/arm: Split out do_neon_ddda, Richard Henderson, 2021/05/24
- [PATCH v7 84/92] target/arm: Split out do_neon_ddda_fpst, Richard Henderson, 2021/05/24
- [PATCH v7 88/92] target/arm: Split decode of VSDOT and VUDOT, Richard Henderson, 2021/05/24
- [PATCH v7 89/92] target/arm: Implement aarch32 VSUDOT, VUSDOT, Richard Henderson, 2021/05/24
- [PATCH v7 86/92] target/arm: Fix decode for VDOT (indexed),
Richard Henderson <=
- [PATCH v7 90/92] target/arm: Implement integer matrix multiply accumulate, Richard Henderson, 2021/05/24
- [PATCH v7 92/92] target/arm: Enable SVE2 and related extensions, Richard Henderson, 2021/05/24
- [PATCH v7 91/92] linux-user/aarch64: Enable hwcap bits for sve2 and related extensions, Richard Henderson, 2021/05/24
- Re: [PATCH v7 00/92] target/arm: Implement SVE2, no-reply, 2021/05/24
- Re: [PATCH v7 00/92] target/arm: Implement SVE2, Peter Maydell, 2021/05/25