Re: [PATCH] Adding ifdefs to call the respective routines only when their configs are enabled

[no-reply]

Patchew URL: 
20210524225608.3191809-1-swethajoshi139@gmail.com/">https://patchew.org/QEMU/20210524225608.3191809-1-swethajoshi139@gmail.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210524225608.3191809-1-swethajoshi139@gmail.com
Subject: [PATCH] Adding ifdefs to call the respective routines only when their 
configs are enabled

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20210524225608.3191809-1-swethajoshi139@gmail.com 
-> patchew/20210524225608.3191809-1-swethajoshi139@gmail.com
Switched to a new branch 'test'
18cab39 Adding ifdefs to call the respective routines only when their configs 
are enabled

=== OUTPUT BEGIN ===
ERROR: suspect code indent for conditional statements (16, 18)
#38: FILE: target/arm/kvm64.c:1433:
+                if (acpi_ghes_record_errors(ACPI_HEST_SRC_ID_SEA, paddr)) {
+                  error_report("failed to record the error");

total: 1 errors, 0 warnings, 28 lines checked

Commit 18cab39bcd46 (Adding ifdefs to call the respective routines only when 
their configs are enabled) has style problems, please review.  If any of these 
errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20210524225608.3191809-1-swethajoshi139@gmail.com/testing.checkpatch/?type=message">http://patchew.org/logs/20210524225608.3191809-1-swethajoshi139@gmail.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com