[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 01/33] block/nbd: fix channel object leak
From: |
Eric Blake |
Subject: |
Re: [PATCH v3 01/33] block/nbd: fix channel object leak |
Date: |
Mon, 24 May 2021 16:31:01 -0500 |
User-agent: |
NeoMutt/20210205 |
On Fri, Apr 16, 2021 at 11:08:39AM +0300, Vladimir Sementsov-Ogievskiy wrote:
> From: Roman Kagan <rvkagan@yandex-team.ru>
>
> nbd_free_connect_thread leaks the channel object if it hasn't been
> stolen.
>
> Unref it and fix the leak.
>
> Signed-off-by: Roman Kagan <rvkagan@yandex-team.ru>
> ---
> block/nbd.c | 1 +
> 1 file changed, 1 insertion(+)
Does nbd_yank() have a similar problem?
At any rate, this makes sense to me.
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
- Re: [PATCH v3 01/33] block/nbd: fix channel object leak,
Eric Blake <=