|
From: | Richard Henderson |
Subject: | Re: [PATCH v4 2/5] target/ppc: used ternary operator when registering MAS |
Date: | Mon, 24 May 2021 10:32:18 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 |
On 5/24/21 6:59 AM, Bruno Larsen (billionai) wrote:
The write calback decision when registering the MAS SPR has been turned into a ternary operation, rather than an if-then-else block. Signed-off-by: Bruno Larsen (billionai)<bruno.larsen@eldorado.org.br> Suggested-by: Richard Henderson<richard.henderson@linaro.org> --- target/ppc/cpu_init.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-)
The commit message here says what, but it doesn't say why.The important part of the change is making the references to spr_write_generic* conditional, via SYS_ARG(), so that the code compiles out for !CONFIG_TCG.
The actual code change is fine: Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
[Prev in Thread] | Current Thread | [Next in Thread] |