[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 3/6] file-posix: fix max_iov for /dev/sg devices
From: |
Paolo Bonzini |
Subject: |
[PATCH v2 3/6] file-posix: fix max_iov for /dev/sg devices |
Date: |
Mon, 24 May 2021 18:36:42 +0200 |
Even though it was only called for devices that have bs->sg set (which
must be character devices),
sg_get_max_segments looked at /sys/dev/block which only works for
block devices.
On Linux the sg driver has its own way to provide the maximum number of
iovecs in a scatter/gather list.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
block/file-posix.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/block/file-posix.c b/block/file-posix.c
index e5ef006aee..77a45083a6 100644
--- a/block/file-posix.c
+++ b/block/file-posix.c
@@ -1179,6 +1179,17 @@ static int sg_get_max_segments(int fd, struct stat *st)
int sysfd = -1;
long max_segments;
+ if (S_ISCHR(st->st_mode)) {
+ if (ioctl(fd, SG_GET_SG_TABLESIZE, &ret) == 0) {
+ return ret;
+ }
+ return -EIO;
+ }
+
+ if (!S_ISBLK(st->st_mode)) {
+ return -ENOTSUP;
+ }
+
sysfspath = g_strdup_printf("/sys/dev/block/%u:%u/queue/max_segments",
major(st->st_rdev), minor(st->st_rdev));
sysfd = open(sysfspath, O_RDONLY);
--
2.31.1
[PATCH v2 4/6] block: feature detection for host block support, Paolo Bonzini, 2021/05/24
[PATCH v2 6/6] block: detect DKIOCGETBLOCKCOUNT/SIZE before use, Paolo Bonzini, 2021/05/24
[PATCH v2 5/6] block: check for sys/disk.h, Paolo Bonzini, 2021/05/24