[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 0/9] qapi: untie 'if' conditions from C preprocessor
|
From: |
Markus Armbruster |
|
Subject: |
Re: [PATCH v4 0/9] qapi: untie 'if' conditions from C preprocessor |
|
Date: |
Fri, 21 May 2021 17:24:10 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Since I won't be able to complete my review before my vaction, let me at
least give you some high-level feedback.
I admit I'm rather fond of the the radically simple, stupid way 'if'
works. It's tied to C, which is just fine as long as all we need is C.
Since we're going to need more than C, it's no longer fine. You replace
the stupid C preprocessor expression string by a little language. The
little language is less expressive than C preprocessor expressions. I
agree with that choice. Simplicity is more important than
expressiveness we may well never need.
I'm a bit concerned about excessive OO boilerplate on the one hand, and
keeping stuff factored cleanly on the other hand. Balancing act. We'll
figure it out.
- [PATCH v4 5/9] qapi: add IfNot, (continued)
- [PATCH v4 5/9] qapi: add IfNot, marcandre . lureau, 2021/05/17
- [PATCH v4 6/9] qapi: normalize 'if' condition to IfPredicate tree, marcandre . lureau, 2021/05/17
- [PATCH v4 7/9] qapi: convert 'if' C-expressions to the new syntax tree, marcandre . lureau, 2021/05/17
- [PATCH v4 9/9] docs: update the documentation about schema configuration, marcandre . lureau, 2021/05/17
- [PATCH v4 8/9] qapi: make 'if' condition strings simple identifiers, marcandre . lureau, 2021/05/17
- Re: [PATCH v4 0/9] qapi: untie 'if' conditions from C preprocessor,
Markus Armbruster <=