[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 12/25] virtio-gpu: move virgl realize + properties
From: |
Gerd Hoffmann |
Subject: |
Re: [PULL 12/25] virtio-gpu: move virgl realize + properties |
Date: |
Fri, 21 May 2021 15:57:12 +0200 |
Hi,
> Sorry for catching this a bit late, but libvirt is looking for "virgl"
> property when guest XML has 3D acceleration enabled:
Yes, libvirt must be adapted to this.
https://gitlab.com/libvirt/libvirt/-/issues/167
As far I know libvirt checks whenever the virgl property exists to
figure whenever virgl support is available (as you can compile qemu
without virgl support). So without changes libvirt will simply
think there is no 3d support and configurations without virgl enables
should continue to work fine.
Configurations with virgl enabled will break though, and unfortunaly
there is no easy way to avoid that.
> The commit message suggests that virtio-gpu-gl-device should be used
> instead. Fair enough, so IIUC the cmd line should be changed to:
>
> -device virtio-gpu-gl-device,id=video0,max_outputs=1,bus=pci.0,addr=0x2
virtio-gpu-gl-device is the mmio variant, for pci you need
virtio-gpu-gl-pci. But otherwise yes, this is what libvirt should use
in case it figures qemu supports the virtio-gpu-gl-pci device (again,
when compiling with virgl disabled the device will not be there).
take care,
Gerd
- [PULL 05/25] edid: Make refresh rate configurable, (continued)
- [PULL 05/25] edid: Make refresh rate configurable, Gerd Hoffmann, 2021/05/10
- [PULL 06/25] edid: move timing generation into a separate function, Gerd Hoffmann, 2021/05/10
- [PULL 08/25] edid: add support for DisplayID extension (5k resolution), Gerd Hoffmann, 2021/05/10
- [PULL 07/25] edid: allow arbitrary-length checksums, Gerd Hoffmann, 2021/05/10
- [PULL 10/25] virtio-gpu: rename virgl source file., Gerd Hoffmann, 2021/05/10
- [PULL 11/25] virtio-gpu: add virtio-gpu-gl-device, Gerd Hoffmann, 2021/05/10
- [PULL 12/25] virtio-gpu: move virgl realize + properties, Gerd Hoffmann, 2021/05/10
- [PULL 09/25] virtio-gpu: handle partial maps properly, Gerd Hoffmann, 2021/05/10
- [PULL 14/25] virtio-gpu: use class function for ctrl queue handlers, Gerd Hoffmann, 2021/05/10
- [PULL 13/25] virtio-gpu: move virgl reset, Gerd Hoffmann, 2021/05/10
- [PULL 15/25] virtio-gpu: move virgl handle_ctrl, Gerd Hoffmann, 2021/05/10
- [PULL 16/25] virtio-gpu: move virgl gl_flushed, Gerd Hoffmann, 2021/05/10
- [PULL 17/25] virtio-gpu: move virgl process_cmd, Gerd Hoffmann, 2021/05/10
- [PULL 18/25] virtio-gpu: move update_cursor_data, Gerd Hoffmann, 2021/05/10
- [PULL 20/25] virtio-gpu: move virtio-gpu-gl-device to separate module, Gerd Hoffmann, 2021/05/10
- [PULL 19/25] virtio-gpu: drop VIRGL() macro, Gerd Hoffmann, 2021/05/10
- [PULL 21/25] virtio-gpu: drop use_virgl_renderer, Gerd Hoffmann, 2021/05/10