[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 1/6] qapi/parser: fix unused check_args_section arguments
From: |
John Snow |
Subject: |
[PATCH v2 1/6] qapi/parser: fix unused check_args_section arguments |
Date: |
Thu, 20 May 2021 18:57:05 -0400 |
Pylint informs us we're not using these arguments. Oops, it's
right. Correct the error message and remove the remaining unused
parameter.
Fix test output now that the error message is improved.
Fixes: e151941d1b
Signed-off-by: John Snow <jsnow@redhat.com>
---
scripts/qapi/parser.py | 16 +++++++++-------
tests/qapi-schema/doc-bad-feature.err | 2 +-
2 files changed, 10 insertions(+), 8 deletions(-)
diff --git a/scripts/qapi/parser.py b/scripts/qapi/parser.py
index 06167ed3e0a..b6a5e661215 100644
--- a/scripts/qapi/parser.py
+++ b/scripts/qapi/parser.py
@@ -753,16 +753,18 @@ def check_expr(self, expr):
def check(self):
- def check_args_section(args, info, what):
+ def check_args_section(args, what):
bogus = [name for name, section in args.items()
if not section.member]
if bogus:
raise QAPISemError(
self.info,
- "documented member%s '%s' %s not exist"
- % ("s" if len(bogus) > 1 else "",
- "', '".join(bogus),
- "do" if len(bogus) > 1 else "does"))
+ "documented %s%s '%s' %s not exist" % (
+ what,
+ "s" if len(bogus) > 1 else "",
+ "', '".join(bogus),
+ "do" if len(bogus) > 1 else "does"
+ ))
- check_args_section(self.args, self.info, 'members')
- check_args_section(self.features, self.info, 'features')
+ check_args_section(self.args, 'member')
+ check_args_section(self.features, 'feature')
diff --git a/tests/qapi-schema/doc-bad-feature.err
b/tests/qapi-schema/doc-bad-feature.err
index e4c62adfa3e..49d1746c3d1 100644
--- a/tests/qapi-schema/doc-bad-feature.err
+++ b/tests/qapi-schema/doc-bad-feature.err
@@ -1 +1 @@
-doc-bad-feature.json:3: documented member 'a' does not exist
+doc-bad-feature.json:3: documented feature 'a' does not exist
--
2.30.2
- [PATCH v2 0/6] qapi: static typing conversion, pt5b, John Snow, 2021/05/20
- [PATCH v2 3/6] qapi/parser: add type hint annotations (QAPIDoc), John Snow, 2021/05/20
- [PATCH v2 6/6] qapi/parser: enable pylint checks, John Snow, 2021/05/20
- [PATCH v2 2/6] qapi/parser: Allow empty QAPIDoc Sections, John Snow, 2021/05/20
- [PATCH v2 4/6] qapi/parser: enable mypy checks, John Snow, 2021/05/20
- [PATCH v2 1/6] qapi/parser: fix unused check_args_section arguments,
John Snow <=
- [PATCH v2 5/6] qapi/parser: Silence too-few-public-methods warning, John Snow, 2021/05/20