[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 42/46] softfloat: Move div_floats to softfloat-parts.c.inc
From: |
Peter Maydell |
Subject: |
Re: [PULL 42/46] softfloat: Move div_floats to softfloat-parts.c.inc |
Date: |
Thu, 20 May 2021 18:04:38 +0100 |
On Thu, 20 May 2021 at 17:15, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> On 5/20/21 8:40 AM, Peter Maydell wrote:
> > On Sun, 16 May 2021 at 13:38, Richard Henderson
> > Hi -- Coverity is suspicious about this line (CID 1453209),
> > because udiv_qrrnd()'s prototype is
> > static inline uint64_t udiv_qrnnd(uint64_t *r, uint64_t n1,
> > uint64_t n0, uint64_t d)
> >
> > but here we pass n0, n1 rather than n1, n0...
> >
> > Bug, or false positive ?
>
> I think it's a false positive.
>
> Different naming schemes between gcc (from whence qrrnd came, 0 as least
> significant element) and the Berkeley softfloat code (0 as most significant
> element).
OK; I've marked it as an fp in the coverity UI.
thanks
-- PMM
- [PULL 35/46] softfloat: Implement float128_add/sub via parts, (continued)
- [PULL 35/46] softfloat: Implement float128_add/sub via parts, Richard Henderson, 2021/05/16
- [PULL 37/46] softfloat: Move muladd_floats to softfloat-parts.c.inc, Richard Henderson, 2021/05/16
- [PULL 32/46] softfloat: Move round_canonical to softfloat-parts.c.inc, Richard Henderson, 2021/05/16
- [PULL 39/46] softfloat: Use add192 in mul128To256, Richard Henderson, 2021/05/16
- [PULL 36/46] softfloat: Move mul_floats to softfloat-parts.c.inc, Richard Henderson, 2021/05/16
- [PULL 41/46] softfloat: Introduce sh[lr]_double primitives, Richard Henderson, 2021/05/16
- [PULL 40/46] softfloat: Tidy mul128By64To192, Richard Henderson, 2021/05/16
- [PULL 42/46] softfloat: Move div_floats to softfloat-parts.c.inc, Richard Henderson, 2021/05/16
- [PULL 45/46] softfloat: Move round_to_int to softfloat-parts.c.inc, Richard Henderson, 2021/05/16
- [PULL 44/46] softfloat: Convert float-to-float conversions with float128, Richard Henderson, 2021/05/16
- [PULL 43/46] softfloat: Split float_to_float, Richard Henderson, 2021/05/16
- [PULL 46/46] softfloat: Move round_to_int_and_pack to softfloat-parts.c.inc, Richard Henderson, 2021/05/16
- Re: [PULL 00/46] softfloat: Convert float128 to FloatParts (part 1), no-reply, 2021/05/16
- Re: [PULL 00/46] softfloat: Convert float128 to FloatParts (part 1), Peter Maydell, 2021/05/18