[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 4/6] gitlab-ci: Add ccache in $PATH and display statistics
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v3 4/6] gitlab-ci: Add ccache in $PATH and display statistics |
Date: |
Thu, 20 May 2021 13:27:04 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 |
+Stefan/Daniel
On 5/20/21 10:02 AM, Thomas Huth wrote:
> On 19/05/2021 20.45, Philippe Mathieu-Daudé wrote:
>> If a runner has ccache installed, use it and display statistics
>> at the end of the build.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> ---
>> .gitlab-ci.d/buildtest-template.yml | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/.gitlab-ci.d/buildtest-template.yml
>> b/.gitlab-ci.d/buildtest-template.yml
>> index f284d7a0eec..a625c697d3b 100644
>> --- a/.gitlab-ci.d/buildtest-template.yml
>> +++ b/.gitlab-ci.d/buildtest-template.yml
>> @@ -6,13 +6,18 @@
>> then
>> JOBS=$(sysctl -n hw.ncpu)
>> MAKE=gmake
>> + PATH=/usr/local/libexec/ccache:$PATH
>> ;
>> else
>> JOBS=$(expr $(nproc) + 1)
>> MAKE=make
>> + PATH=/usr/lib/ccache:/usr/lib64/ccache:$PATH
>
> That does not make sense for the shared runners yet. We first need
> something to enable the caching there - see my series "Use ccache in the
> gitlab-CI" from April (which is currently stalled unfortunately).
TL;DR: I don't think we should restrict our templates to shared runners.
I don't think mainstream interest for shared runners use should limit
forks... This is a great improvement for contributors having to use
private/custom runner, see this example:
https://gitlab.com/philmd/qemu/-/jobs/1255197705
cache hit (direct) 1529
cache hit (preprocessed) 736
cache miss 855
cache hit rate 72.60 %
Having been caught 2 times for testing as hard as crypto miner, I
can not rely on shared runners for my workflow.
Beside, the recent announcement:
https://about.gitlab.com/blog/2021/05/17/prevent-crypto-mining-abuse/
"starting May 17, 2021, GitLab will require new free users to provide a
valid credit or debit card number in order to use shared runners on
GitLab.com."
On this report only 17/142 countries are listed as having more than
50% of their population with a credit card:
https://www.theglobaleconomy.com/rankings/people_with_credit_cards/
and 60 with a debit card:
https://www.theglobaleconomy.com/rankings/people_with_debit_cards/
We have some contributors in countries with low percentage. I don't
think we should start a poll to verify, but I do think relying on
shared runners without proposing free alternative is discriminatory
to a part of our community.
I am very open to alternatives to improve the CI/testing situation.
Regards,
Phil.
- Re: [PATCH v3 2/6] gitlab-ci: Adapt JOBS variable for FreeBSD runners, (continued)
- [PATCH v3 3/6] gitlab-ci: Run GNU make via the $MAKE variable, Philippe Mathieu-Daudé, 2021/05/19
- [PATCH v3 4/6] gitlab-ci: Add ccache in $PATH and display statistics, Philippe Mathieu-Daudé, 2021/05/19
- Re: [PATCH v3 4/6] gitlab-ci: Add ccache in $PATH and display statistics, Willian Rampazzo, 2021/05/19
- Re: [PATCH v3 4/6] gitlab-ci: Add ccache in $PATH and display statistics, Thomas Huth, 2021/05/20
- Re: [PATCH v3 4/6] gitlab-ci: Add ccache in $PATH and display statistics,
Philippe Mathieu-Daudé <=
- Re: [PATCH v3 4/6] gitlab-ci: Add ccache in $PATH and display statistics, Thomas Huth, 2021/05/21
- Re: [PATCH v3 4/6] gitlab-ci: Add ccache in $PATH and display statistics, Daniel P . Berrangé, 2021/05/21
- Re: [PATCH v3 4/6] gitlab-ci: Add ccache in $PATH and display statistics, Thomas Huth, 2021/05/21
- Re: [PATCH v3 4/6] gitlab-ci: Add ccache in $PATH and display statistics, Daniel P . Berrangé, 2021/05/21
- Re: [PATCH v3 4/6] gitlab-ci: Add ccache in $PATH and display statistics, Philippe Mathieu-Daudé, 2021/05/21
- Re: [PATCH v3 4/6] gitlab-ci: Add ccache in $PATH and display statistics, Daniel P . Berrangé, 2021/05/21
- Re: [PATCH v3 4/6] gitlab-ci: Add ccache in $PATH and display statistics, Philippe Mathieu-Daudé, 2021/05/21
- Re: [PATCH v3 4/6] gitlab-ci: Add ccache in $PATH and display statistics, Philippe Mathieu-Daudé, 2021/05/25
- Re: [PATCH v3 4/6] gitlab-ci: Add ccache in $PATH and display statistics, Stefan Hajnoczi, 2021/05/24
- Re: [PATCH v3 4/6] gitlab-ci: Add ccache in $PATH and display statistics, Philippe Mathieu-Daudé, 2021/05/25