[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH 11/11] hw/isa: Rename isabus singleton as 'g_isabus'
From: |
Stefan Hajnoczi |
Subject: |
Re: [RFC PATCH 11/11] hw/isa: Rename isabus singleton as 'g_isabus' |
Date: |
Wed, 19 May 2021 17:18:37 +0100 |
On Tue, May 18, 2021 at 11:55:45PM +0200, Philippe Mathieu-Daudé wrote:
> @@ -55,7 +53,10 @@ static const TypeInfo isa_bus_info = {
> ISABus *isa_bus_new(DeviceState *dev, MemoryRegion* address_space,
> MemoryRegion *address_space_io, Error **errp)
> {
> - if (isabus) {
> + static ISABus *g_isabus;
QEMU doesn't use Hungarian notation, g_isabus isn't a global variable so
the prefix is confusing, and g_ conflicts with GLib's namespace so the
rename is odd. I suggest keeping the name unchanged and making the
commit message "remove the global isabus variable".
signature.asc
Description: PGP signature
- Re: [RFC PATCH 01/11] hw/isa: Explode pci_create_simple() calls, (continued)
- [RFC PATCH 04/11] hw/ide/via: Set the ISA-bus QOM link, Philippe Mathieu-Daudé, 2021/05/18
- [RFC PATCH 05/11] hw/isa: Extract isa_bus_get_irq() from isa_get_irq(), Philippe Mathieu-Daudé, 2021/05/18
- [RFC PATCH 06/11] hw/ide: Replace isa_get_irq() by isa_bus_get_irq(), Philippe Mathieu-Daudé, 2021/05/18
- [RFC PATCH 07/11] hw/isa: Simplify isa_get_irq(), Philippe Mathieu-Daudé, 2021/05/18
- [RFC PATCH 09/11] hw/ide: Let ide_init_ioport() take an ISA bus argument instead of device, Philippe Mathieu-Daudé, 2021/05/18
- [RFC PATCH 08/11] hw/isa: Extract bus part from isa_register_portio_list(), Philippe Mathieu-Daudé, 2021/05/18
- [RFC PATCH 10/11] hw/isa: Remove use of global isa bus, Philippe Mathieu-Daudé, 2021/05/18
- [RFC PATCH 11/11] hw/isa: Rename isabus singleton as 'g_isabus', Philippe Mathieu-Daudé, 2021/05/18
- Re: [RFC PATCH 11/11] hw/isa: Rename isabus singleton as 'g_isabus',
Stefan Hajnoczi <=