[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 01/21] qapi/parser: Don't try to handle file errors
|
From: |
Markus Armbruster |
|
Subject: |
Re: [PATCH v2 01/21] qapi/parser: Don't try to handle file errors |
|
Date: |
Wed, 19 May 2021 08:51:25 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
John Snow <jsnow@redhat.com> writes:
> On 5/18/21 5:28 AM, Markus Armbruster wrote:
>> QAPIError not having .info don't actually exist before this patch.
>
> It's defined by QAPISourceError now, I just missed this spot in
> test-qapi. It isn't used in practice until now, however.
I had QAPIError mentally filed under abstract types / didn't bother to
formally make it one with decorators. Just as well, because it's not
staying abstract: this patch creates instances.
[PATCH v2 06/21] qapi/parser: enforce all top-level expressions must be dict in _parse(), John Snow, 2021/05/11
[PATCH v2 02/21] qapi: Add test for nonexistent schema file, John Snow, 2021/05/11
[PATCH v2 03/21] qapi/source: Remove line number from QAPISourceInfo initializer, John Snow, 2021/05/11
[PATCH v2 07/21] qapi/parser: assert object keys are strings, John Snow, 2021/05/11
[PATCH v2 05/21] qapi/parser: Assert lexer value is a string, John Snow, 2021/05/11
[PATCH v2 04/21] qapi/parser: factor parsing routine into method, John Snow, 2021/05/11