Re: [PATCH 18/21] block/block-copy: make setting progress optional

[Max Reitz]

On 17.05.21 08:44, Vladimir Sementsov-Ogievskiy wrote:
> Now block-copy will crash if user don't set progress meter by
> block_copy_set_progress_meter(). copy-before-write filter will be used
> in separate of backup job, and it doesn't want any progress meter (for
> now). So, allow not setting it.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
>   block/block-copy.c | 18 +++++++++++-------
>   1 file changed, 11 insertions(+), 7 deletions(-)

Makes me wonder whether an “if (not NULL)” check in progress_meter.h 
wouldn’t be a nice addition, but:

Reviewed-by: Max Reitz <mreitz@redhat.com>