Re: [PATCH] qemu-config: load modules when instantiating option groups

[no-reply]

Patchew URL: 
20210518131542.2941207-1-pbonzini@redhat.com/">https://patchew.org/QEMU/20210518131542.2941207-1-pbonzini@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210518131542.2941207-1-pbonzini@redhat.com
Subject: [PATCH] qemu-config: load modules when instantiating option groups

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
   8e22b27..15e147b  master     -> master
 - [tag update]      patchew/20210517064428.16223-1-vsementsov@virtuozzo.com -> 
patchew/20210517064428.16223-1-vsementsov@virtuozzo.com
 * [new tag]         patchew/20210518131542.2941207-1-pbonzini@redhat.com -> 
patchew/20210518131542.2941207-1-pbonzini@redhat.com
Switched to a new branch 'test'
caeb56b qemu-config: load modules when instantiating option groups

=== OUTPUT BEGIN ===
ERROR: do not initialise statics to 0 or NULL
#51: FILE: softmmu/vl.c:2620:
+    static bool spice_tried = false;

ERROR: do not initialise statics to 0 or NULL
#57: FILE: softmmu/vl.c:2626:
+    static bool iscsi_tried = false;

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#92: 
new file mode 100644

total: 2 errors, 1 warnings, 61 lines checked

Commit caeb56b0e05f (qemu-config: load modules when instantiating option 
groups) has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20210518131542.2941207-1-pbonzini@redhat.com/testing.checkpatch/?type=message">http://patchew.org/logs/20210518131542.2941207-1-pbonzini@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com