qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 00/50] target/i386 translate cleanups


From: Paolo Bonzini
Subject: Re: [PATCH v2 00/50] target/i386 translate cleanups
Date: Tue, 18 May 2021 14:33:18 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1

On 18/05/21 12:59, Richard Henderson wrote:
On 5/18/21 5:31 AM, Paolo Bonzini wrote:
On 14/05/21 17:12, Richard Henderson wrote:
Supercedes: 20210228232321.322053-1-richard.henderson@linaro.org
("i386 cleanup part 3")

Claudio's prerequite patch set ("i386 cleanup part 2"), is now merged.
Version 2 here fixes some minor rebase conflicts that crept in.
Only 4 of the 50 patches have been reviewed.

Blurb from v1:
This started out to address a fixme in Claudio's patch set, then
wandered a bit, with cleanups and bug fixes in the code that I was
touching.  I stopped when I reached my original goal of removing
target/i386/tcg/user/*_stubs.c.

There are a lot of patches, but hopefully they're all small
enough to be obvious.

Nice, thanks.  I only left minor comments on 27 and 30, feel free to do a pull request without v3.

Shall I take your comments then as "... Otherwise, R-B"?
Because you didn't actually give them for those two, and they're the only two without r-b tags.

You treated patch 49 similarly, but that one already had Phil's r-b.

Well you're a maintainer so you don't really need R-b's but just to be precise: 27 would be completely different, while 30 should have had a r-b (it's just a commit message suggestion) and 49 should have had an "otherwise r-b".

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]