qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 6/9] qapi: normalize 'if' condition to IfPredicate tree


From: John Snow
Subject: Re: [PATCH v3 6/9] qapi: normalize 'if' condition to IfPredicate tree
Date: Mon, 17 May 2021 12:41:28 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1

On 5/17/21 7:18 AM, Marc-André Lureau wrote:


    'if': 'COND'
    'if': ['COND']
    'if': { 'any': ['COND'] }


Actually, a simple list is short form for { 'all': [] }

Typo on my part. It maintains compatibility with what it used to mean, so it's good.

I wonder if we want *three* forms available directly in the schema. Can we condense it back down to two somehow? Could we possibly remove the list-less form?

(The less forms we have, the easier it is to offer e.g. intellisense plugins for vscode and things of that nature, which is something I have an interest in to improve the usability of the generator for contributors who are less invested in the QAPI subsystem.)

--js




reply via email to

[Prev in Thread] Current Thread [Next in Thread]