Re: [PATCH v2 12/12] hw/ppc/Kconfig: Add dependency PEGASOS2 -> ATI_VGA

[David Gibson]

On Sat, May 15, 2021 at 07:37:16PM +0200, Philippe Mathieu-Daudé wrote:
> From: Philippe Mathieu-Daudé <f4bug@amsat.org>
> 
> While the ATI VGA device isn't a requisite (no crash without it):
> 
>   $ qemu-system-ppc -M pegasos2
>   qemu-system-ppc: standard VGA not available
> 
> it is useful to have it with the Pegasos2 machine:
> 
>   $ qemu-system-ppc -M pegasos2 -vga none -bios pegasos2.rom -device 
> ati-vga,romfile=
>   qemu-system-ppc: -device ati-vga,romfile=: 'ati-vga' is not a valid device 
> model name
> 
> Add it as an implicit Kconfig dependency.
> 
> Fixes: ba7e5ac18e7 ("hw/ppc: Add emulation of Genesi/bPlan Pegasos II")
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Acked-by: David Gibson <david@gibson.dropbear.id.au>

> ---
>  hw/ppc/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/ppc/Kconfig b/hw/ppc/Kconfig
> index 2e4c56eb770..e36db08665a 100644
> --- a/hw/ppc/Kconfig
> +++ b/hw/ppc/Kconfig
> @@ -77,6 +77,7 @@ config PEGASOS2
>      select SMBUS_EEPROM
>  # This should come with VT82C686
>      select ACPI_X86
> +    imply ATI_VGA
>  
>  config PREP
>      bool

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

signature.asc
Description: PGP signature