Re: [PATCH v6 77/82] target/arm: Fix decode for VDOT (indexed)

[Richard Henderson]

On 5/13/21 2:25 PM, Peter Maydell wrote:
> > +static bool do_neon_ddda(DisasContext *s, int q, int vd, int vn, int vm,
> > +                         int data, gen_helper_gvec_4 *fn_gvec)
>
> This patch seems to be doing more than its commit message suggests.
> If we want to share code between trans_VDOT and trans_VDOT_scalar
> can we do that refactoring in its own patch, please ?

It appears as if a rebasing error squashed two patches together
(git commit --amend vs git rebase --continue after conflicts).

I nearly made the identical mistake while splitting this apart again just now.  
:-P


r~