Re: [PATCH v6 80/82] target/arm: Implement integer matrix multiply accumulate

[Richard Henderson]

On 5/13/21 2:49 PM, Peter Maydell wrote:
> On Fri, 30 Apr 2021 at 22:36, Richard Henderson
> <richard.henderson@linaro.org> wrote:
> > This is {S,U,US}MMLA for both AArch64 AdvSIMD and SVE,
> > and V{S,U,US}MMLA.S8 for AArch32 NEON.
> >
> > Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> > ---
> >   target/arm/helper.h           |  7 ++++
> >   target/arm/neon-shared.decode |  7 ++++
> >   target/arm/sve.decode         |  6 +++
> >   target/arm/translate-a64.c    | 18 ++++++++
> >   target/arm/translate-neon.c   | 27 ++++++++++++
> >   target/arm/translate-sve.c    | 27 ++++++++++++
> >   target/arm/vec_helper.c       | 77 +++++++++++++++++++++++++++++++++++
> >   7 files changed, 169 insertions(+)
>
> I have to say the decode parts for SVE and A32 (using decodetree
> were much easier to review than the A64 part...

Indeed, this was painful enough to write that I'm on the verge of converting 
a64 to decodetree as well.


r~