Re: [PATCH 00/14] vl: compound properties for machines and accelerators

[no-reply]

Patchew URL: 
20210513162901.1310239-1-pbonzini@redhat.com/">https://patchew.org/QEMU/20210513162901.1310239-1-pbonzini@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210513162901.1310239-1-pbonzini@redhat.com
Subject: [PATCH 00/14] vl: compound properties for machines and accelerators

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20210513162901.1310239-1-pbonzini@redhat.com -> 
patchew/20210513162901.1310239-1-pbonzini@redhat.com
Switched to a new branch 'test'
f11df8b machine: add smp compound property
056a1f3 machine: reject -smp dies!=1 for non-PC machines
f9a9ed1 machine: pass QAPI struct to mc->smp_parse
ccdb728 machine: add error propagation to mc->smp_parse
36dc3c3 machine: move common smp_parse code to caller
c547aa6 machine: move dies from X86MachineState to CpuTopology
4fa41d4 vl: switch -accel parsing to keyval
51375fd qemu-option: remove now-dead code
a91c274 vl: switch -M parsing to keyval
3bafa79 keyval: introduce keyval_parse_into
237070b qom: export more functions for use with non-UserCreatable objects
06ecbc4 vl: plumb keyval-based options into -set and -readconfig
105227f qemu-config: parse configuration files to a QDict
0e653b3 remove -writeconfig

=== OUTPUT BEGIN ===
1/14 Checking commit 0e653b38c051 (remove -writeconfig)
2/14 Checking commit 105227fb9596 (qemu-config: parse configuration files to a 
QDict)
WARNING: line over 80 characters
#31: FILE: include/qemu/config-file.h:4:
+typedef void QEMUConfigCB(const char *group, QDict *qdict, void *opaque, Error 
**errp);

WARNING: line over 80 characters
#41: FILE: include/qemu/config-file.h:18:
+void qemu_config_do_parse(const char *group, QDict *qdict, void *opaque, Error 
**errp);

WARNING: line over 80 characters
#65: FILE: softmmu/vl.c:3372:
+                qemu_read_config_file(optarg, qemu_config_do_parse, 
&error_fatal);

WARNING: line over 80 characters
#173: FILE: util/qemu-config.c:385:
+void qemu_config_do_parse(const char *group, QDict *qdict, void *opaque, Error 
**errp)

WARNING: line over 80 characters
#195: FILE: util/qemu-config.c:407:
+int qemu_config_parse(FILE *fp, QemuOptsList **lists, const char *fname, Error 
**errp)

total: 0 errors, 5 warnings, 170 lines checked

Patch 2/14 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/14 Checking commit 06ecbc4ad0ba (vl: plumb keyval-based options into -set and 
-readconfig)
WARNING: line over 80 characters
#117: FILE: softmmu/vl.c:2148:
+static KeyvalConfigEntry *qemu_find_config(KeyvalConfigGroup *head, const char 
*id)

ERROR: line over 90 characters
#129: FILE: softmmu/vl.c:2160:
+static void qemu_record_config_group(const char *group, QDict *dict, bool 
from_json, Error **errp)

WARNING: line over 80 characters
#144: FILE: softmmu/vl.c:2175:
+static void qemu_set_qdict_option(QDict *dict, const char *key, const char 
*value,

WARNING: line over 80 characters
#174: FILE: softmmu/vl.c:2205:
+        error_setg(errp, "Lists cannot be at top level of a configuration 
section");

WARNING: line over 80 characters
#223: FILE: softmmu/vl.c:2247:
+            error_setg(errp, "cannot use -set with %s \"%s\" passed as JSON", 
group, id);

WARNING: line over 80 characters
#272: FILE: softmmu/vl.c:3476:
+                qemu_read_config_file(optarg, qemu_parse_config_group, 
&error_fatal);

ERROR: line over 90 characters
#290: FILE: tests/unit/test-keyval.c:756:
+    QDict *combined = 
keyval_parse("opt1=ABC,opt2.sub1=def,opt2.sub2=GHI,opt2.sub3=JKL,opt3=xyz",

WARNING: line over 80 characters
#359: FILE: util/keyval.c:314:
+static void keyval_do_merge(QDict *old, const QDict *new, GString *str, Error 
**errp)

ERROR: line over 90 characters
#369: FILE: util/keyval.c:324:
+                error_setg(errp, "Parameter '%s%s' used inconsistently", 
str->str, ent->key);

total: 3 errors, 6 warnings, 344 lines checked

Patch 3/14 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/14 Checking commit 237070ba2b31 (qom: export more functions for use with 
non-UserCreatable objects)
5/14 Checking commit 3bafa79a7738 (keyval: introduce keyval_parse_into)
WARNING: line over 80 characters
#26: FILE: include/qemu/option.h:150:
+QDict *keyval_parse_into(QDict *qdict, const char *params, const char 
*implied_key,

WARNING: line over 80 characters
#48: FILE: util/keyval.c:486:
+QDict *keyval_parse_into(QDict *qdict, const char *params, const char 
*implied_key,

total: 0 errors, 2 warnings, 78 lines checked

Patch 5/14 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/14 Checking commit a91c274e99f7 (vl: switch -M parsing to keyval)
WARNING: line over 80 characters
#206: FILE: softmmu/vl.c:1586:
+            error_setg(&local_err, "No machine specified, and there is no 
default");

WARNING: line over 80 characters
#219: FILE: softmmu/vl.c:1592:
+        error_append_hint(&local_err, "Use -machine help to list supported 
machines\n");

WARNING: line over 80 characters
#256: FILE: softmmu/vl.c:1633:
+            error_setg(errp, "Conflict between '%s' and '%s'", ent->key, 
new_key);

WARNING: line over 80 characters
#300: FILE: softmmu/vl.c:1657:
+        object_register_sugar_prop(ACCEL_CLASS_NAME("xen"), "igd-passthru", 
value,

WARNING: line over 80 characters
#307: FILE: softmmu/vl.c:1664:
+        object_register_sugar_prop(ACCEL_CLASS_NAME("kvm"), "kvm-shadow-mem", 
value,

WARNING: line over 80 characters
#314: FILE: softmmu/vl.c:1671:
+        object_register_sugar_prop(ACCEL_CLASS_NAME("kvm"), "kernel-irqchip", 
value,

WARNING: line over 80 characters
#316: FILE: softmmu/vl.c:1673:
+        object_register_sugar_prop(ACCEL_CLASS_NAME("whpx"), "kernel-irqchip", 
value,

ERROR: line over 90 characters
#338: FILE: softmmu/vl.c:1794:
+    object_set_properties_from_keyval(OBJECT(current_machine), qdict, false, 
&error_fatal);

ERROR: line over 90 characters
#350: FILE: softmmu/vl.c:1824:
+        semihosting_arg_fallback(current_machine->kernel_filename, 
current_machine->kernel_cmdline);

ERROR: code indent should never use tabs
#414: FILE: softmmu/vl.c:2147:
+^I * Cannot merge string-valued and type-safe dictionaries, so JSON$

ERROR: code indent should never use tabs
#415: FILE: softmmu/vl.c:2148:
+^I * is not accepted yet for -M.$

ERROR: code indent should never use tabs
#416: FILE: softmmu/vl.c:2149:
+^I */$

ERROR: line over 90 characters
#526: FILE: softmmu/vl.c:3277:
+                    keyval_parse_into(machine_opts_dict, optarg, "type", 
&help, &error_fatal);

total: 6 errors, 7 warnings, 536 lines checked

Patch 6/14 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

7/14 Checking commit 51375fdf61c2 (qemu-option: remove now-dead code)
8/14 Checking commit 4fa41d4803b8 (vl: switch -accel parsing to keyval)
WARNING: line over 80 characters
#29: FILE: accel/accel-softmmu.c:35:
+    g_autofree char *class_name = g_strdup_printf(ACCEL_CLASS_NAME("%s"), 
opt_name);

ERROR: "(foo*)" should be "(foo *)"
#134: FILE: softmmu/vl.c:2140:
+        args = (QDict*) qobject_from_json(arg, errp);

WARNING: line over 80 characters
#187: FILE: softmmu/vl.c:2279:
+    object_set_properties_from_keyval(OBJECT(accel), e->dict, e->from_json, 
&error_fatal);

WARNING: line over 80 characters
#194: FILE: softmmu/vl.c:2284:
+            error_report("failed to initialize %s: %s", ac->name, 
strerror(-ret));

WARNING: line over 80 characters
#315: FILE: softmmu/vl.c:3303:
+                    args = qemu_parse_config_option("accel", optarg, &help, 
&error_fatal);

total: 1 errors, 4 warnings, 285 lines checked

Patch 8/14 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

9/14 Checking commit c547aa618036 (machine: move dies from X86MachineState to 
CpuTopology)
10/14 Checking commit 36dc3c38ee59 (machine: move common smp_parse code to 
caller)
11/14 Checking commit ccdb728e4ee8 (machine: add error propagation to 
mc->smp_parse)
12/14 Checking commit f9a9ed171915 (machine: pass QAPI struct to mc->smp_parse)
WARNING: line over 80 characters
#95: FILE: hw/i386/pc.c:709:
+static void pc_smp_parse(MachineState *ms, SMPConfiguration *config, Error 
**errp)

total: 0 errors, 1 warnings, 133 lines checked

Patch 12/14 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
13/14 Checking commit 056a1f3633ba (machine: reject -smp dies!=1 for non-PC 
machines)
14/14 Checking commit f11df8b988ce (machine: add smp compound property)
ERROR: line over 90 characters
#223: FILE: softmmu/vl.c:3349:
+                machine_parse_property_opt(qemu_find_opts("smp-opts"), "smp", 
optarg, &error_fatal);

WARNING: line over 80 characters
#236: FILE: tests/qtest/numa-test.c:28:
+    cli = make_cli(data, "-machine smp.cpus=8 -numa 
node,nodeid=0,memdev=ram,cpus=0-3 "

WARNING: line over 80 characters
#245: FILE: tests/qtest/numa-test.c:45:
+    cli = make_cli(data, "-machine smp.cpus=8 -numa node,memdev=ram -numa 
node");

ERROR: line over 90 characters
#272: FILE: tests/qtest/numa-test.c:127:
+    cli = make_cli(data, "-cpu pentium -machine 
smp.cpus=8,smp.sockets=2,smp.cores=2,smp.threads=2 "

total: 2 errors, 2 warnings, 277 lines checked

Patch 14/14 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20210513162901.1310239-1-pbonzini@redhat.com/testing.checkpatch/?type=message">http://patchew.org/logs/20210513162901.1310239-1-pbonzini@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com