Re: [PATCH v6 60/82] target/arm: Implement SVE mixed sign dot product

[Peter Maydell]

On Fri, 30 Apr 2021 at 22:00, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  target/arm/helper.h        |  2 ++
>  target/arm/sve.decode      |  4 ++++
>  target/arm/translate-sve.c | 16 ++++++++++++++++
>  target/arm/vec_helper.c    | 18 ++++++++++++++++++
>  4 files changed, 40 insertions(+)
>
> diff --git a/target/arm/helper.h b/target/arm/helper.h
> index e4c6458f98..86f938c938 100644
> --- a/target/arm/helper.h
> +++ b/target/arm/helper.h
> @@ -612,6 +612,8 @@ DEF_HELPER_FLAGS_5(gvec_sdot_b, TCG_CALL_NO_RWG, void, 
> ptr, ptr, ptr, ptr, i32)
>  DEF_HELPER_FLAGS_5(gvec_udot_b, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, ptr, 
> i32)
>  DEF_HELPER_FLAGS_5(gvec_sdot_h, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, ptr, 
> i32)
>  DEF_HELPER_FLAGS_5(gvec_udot_h, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, ptr, 
> i32)
> +DEF_HELPER_FLAGS_5(gvec_usdot_b, TCG_CALL_NO_RWG,
> +                   void, ptr, ptr, ptr, ptr, i32)

This is one of those places where I'd take the long line even if
checkpatch complains,
just to maintain the parallelism with the preceding lines, but wrapping
is fine too.

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM