qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 31/72] softfloat: Move sf_canonicalize to softfloat-parts.c.i


From: Alex Bennée
Subject: Re: [PATCH 31/72] softfloat: Move sf_canonicalize to softfloat-parts.c.inc
Date: Thu, 13 May 2021 10:45:52 +0100
User-agent: mu4e 1.5.13; emacs 28.0.50

Richard Henderson <richard.henderson@linaro.org> writes:

> At the same time, convert to pointers, rename to parts$N_canonicalize
> and define a macro for parts_canonicalize using QEMU_GENERIC.

You also changed the ordering of checks and the likely/unlikey
conditions which would be worth mentioning why in the commit. Otherwise
looks good to me:

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

-- 
Alex Bennée



reply via email to

[Prev in Thread] Current Thread [Next in Thread]